Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redelegateInfo #692

Closed
wants to merge 1 commit into from
Closed

Fix redelegateInfo #692

wants to merge 1 commit into from

Conversation

mogithehurt
Copy link
Contributor

Description

Fix redelegateInfo

Type of change

Please delete options that are not relevant.

  • Improvements (ie: code cleaning or remove unused codes or performance issue)

@HuberTRoy
Copy link
Member

Thanks for your PR.

Looks like there no problems at i18n file. It's a placeholder.

The problem seems like at here https://github.com/subquery/network-app/blob/main/src/pages/delegator/DoDelegate/DelegateFrom.tsx#L418.

Can you please change it? I think make it with useMemo would be good.

@mogithehurt
Copy link
Contributor Author

Thanks for your PR.

Looks like there no problems at i18n file. It's a placeholder.

The problem seems like at here https://github.com/subquery/network-app/blob/main/src/pages/delegator/DoDelegate/DelegateFrom.tsx#L418.

Can you please change it? I think make it with useMemo would be good.

this pr is not related to #691, this is fixing redelegateInfo sentence.

@HuberTRoy
Copy link
Member

HuberTRoy commented Mar 21, 2024

Yes, I fixed your #691 at #693.

The sentence on i18n is good.

If re-delegate trigger from delegate, the placeholder of re-delegate should be

t('delegate.redelegateInfo', {
  reIndexerName: selectedOption?.name,
  indexerName: indexerMetadata.name,
})

if re-delegate trigger from undelegate, the placeholder of re-delegate should be

t('delegate.redelegateInfo', {
  reIndexerName:  indexerMetadata.name,
  indexerName: selectedOption?.name,
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants